This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386]: Remove unneeded ATTRIBUTE_UNUSED decorations


On Mon, Aug 26, 2013 at 11:13 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Mon, Aug 26, 2013 at 11:04:42AM +0200, Uros Bizjak wrote:
>>  static bool
>> -ix86_return_in_memory (const_tree type, const_tree fntype ATTRIBUTE_UNUSED)
>> +ix86_return_in_memory (const_tree type, const_tree fntype)
>>  {
>>  #ifdef SUBTARGET_RETURN_IN_MEMORY
>>    return SUBTARGET_RETURN_IN_MEMORY (type, fntype);
>
> This doesn't look right, because the SUBTARGET_RETURN_IN_MEMORY
> definitions (interix and i386elf) don't mention the FNTYPE anywhere.

Uh, I missed the "#else".

Fixed in a followup patch.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]