This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch 2/2] Localization problem in regex


Hi,

On 08/23/2013 11:17 AM, Tim Shen wrote:
     2013-08-23  Tim Shen<timshen91@gmail.com>
* include/bits/regex.h: Fix callers.
     	* include/bits/regex_compiler.h: Store _Traits reference.
     	* include/bits/regex_executor.h: Add _Traits member for _DFSExecutor.
     	* include/bits/regex_executor.tcc: Likewise.
     	* testsuite/28_regex/algorithms/regex_match/extended/wstring_locale.cc:
     	  New.
Thanks a lot indeed. But: "Fix callers" of *what*?!? And from *where*? To be really honest this kind of ChangeLog entry doesn't make much sense. Please get used to list the specific functions you are changing. It's important.

Thanks,
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]