This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Enable non-complex math builtins from C99 for Bionic
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Alexander Ivchenko <aivchenk at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 22 Aug 2013 10:25:00 +0200
- Subject: Re: [PATCH] Enable non-complex math builtins from C99 for Bionic
- References: <Pine dot LNX dot 4 dot 64 dot 1211302115430 dot 10739 at digraph dot polyomino dot org dot uk> <CACysShjuePdWP1fDQ+=pbUQYjQDyzu3u1ypLfHsOf8-gjpDo5Q at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1212191754480 dot 3536 at digraph dot polyomino dot org dot uk> <CACysShhnjtoco63R1BsAPNiD=jB696e-1FOekC0f40YLFk9WrQ at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1301071615250 dot 23785 at digraph dot polyomino dot org dot uk> <CACysShhz+0gyscs-fkN7evVq1bGCMmgj09n6YQFAriKKn2C+HA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1307082206160 dot 7307 at digraph dot polyomino dot org dot uk> <CACysShhZkdphnWqy8qaCKotQEp7sYizsGi8ZJ0hg3wBTx7Xenw at mail dot gmail dot com> <yddbo4rw21v dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <CACysShhKGY1UCUthvTmDSeVS7D4QV=BpAD2VbzmPv7wLYYFqhA at mail dot gmail dot com>
On Wed, Aug 21, 2013 at 11:21:32PM +0400, Alexander Ivchenko wrote:
> I'm sorry for that. The following patch cured my build of those
> targets; it is also preserving the initial presence of c99. There were
> plenty of targets that were changed by my patch, I hope this time I
> didn't miss anything.
S/390 bootstrap still fails. The reason is that when we set
tm_file/tm_p_file in config.gcc we do not append to the existing
content so your adjustments done before are ignored and gcc complains
about unknown linux_android_libc_has_function.
However, since with s390 Linux and TPF we only target GNU Linux
systems with Glibc we can default to gnu_libc_has_functions anyway:
Index: gcc/config/s390/linux.h
===================================================================
*** gcc/config/s390/linux.h.orig 2013-01-14 07:48:06.000000000 +0000
--- gcc/config/s390/linux.h 2013-08-22 07:57:46.006014197 +0000
*************** along with GCC; see the file COPYING3.
*** 87,90 ****
--- 87,93 ----
/* Define if long doubles should be mangled as 'g'. */
#define TARGET_ALTERNATE_LONG_DOUBLE_MANGLING
+ #undef TARGET_LIBC_HAS_FUNCTION
+ #define TARGET_LIBC_HAS_FUNCTION gnu_libc_has_function
+
#endif
Index: gcc/config/s390/tpf.h
===================================================================
*** gcc/config/s390/tpf.h.orig 2013-08-22 07:01:48.000000000 +0000
--- gcc/config/s390/tpf.h 2013-08-22 07:57:27.706013534 +0000
*************** along with GCC; see the file COPYING3.
*** 111,118 ****
/* IBM copies these libraries over with these names. */
#define MATH_LIBRARY "CLBM"
#define LIBSTDCXX "CPP2"
- #endif /* ! _TPF_H */
- /* We redefine this hook so the version from elfos.h header won't be used. */
#undef TARGET_LIBC_HAS_FUNCTION
! #define TARGET_LIBC_HAS_FUNCTION default_libc_has_function
--- 111,118 ----
/* IBM copies these libraries over with these names. */
#define MATH_LIBRARY "CLBM"
#define LIBSTDCXX "CPP2"
#undef TARGET_LIBC_HAS_FUNCTION
! #define TARGET_LIBC_HAS_FUNCTION gnu_libc_has_function
!
! #endif /* ! _TPF_H */