This is the mail archive of the
mailing list for the GCC project.
Re: [Google] Refine hot caller heuristic
- From: Xinliang David Li <davidxl at google dot com>
- To: Easwaran Raman <eraman at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Teresa Johnson <tejohnson at google dot com>
- Date: Tue, 20 Aug 2013 21:35:01 -0700
- Subject: Re: [Google] Refine hot caller heuristic
- References: <CAPK5YPbS5mMWvHF_843=MpauLGyEhVJWb6UViV6HAXV8hTy1ig at mail dot gmail dot com>
Do you need to guard the jump function access with check if
Ideally, useful_cold_callee should be folded into the inline hints
estimation. Question about the heuristic: why filtering out
PASS_THROUGH parameter cases completely? Passing 'this' parameter in
many cases can result in good PRE opportunities. Why not skip the
On Tue, Aug 20, 2013 at 12:26 PM, Easwaran Raman <firstname.lastname@example.org> wrote:
> The current hot caller heuristic simply promotes edges whose caller is
> hot. This patch does the following:
> * Turn it off for applications with large footprint since the size
> increase hurts them
> * Be more selective by considering arguments to callee when the
> heuristic is enabled.
> This performs well on internal benchmarks. Ok for google/4_8 branch if
> all tests pass?
> - Easwaran