This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk


Jason: ping ping

rth: BTW, the C front-end changes are here too, hint hint :).

-------- Original Message --------
Subject: Re: [patch] implement Cilk Plus simd loops on trunk
Date: Fri, 26 Jul 2013 17:46:27 +0200
From: Aldy Hernandez <aldyh@redhat.com>
To: Jason Merrill <jason@redhat.com>
CC: Richard Henderson <rth@redhat.com>, "Iyer, Balaji V" <balaji.v.iyer@intel.com>, gcc-patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>

Fixed everything.  Thanks for the review.

+cp_parser_simd_for_init_statement (cp_parser *parser, tree *init,

This seems to be largely copied from cp_parser_omp_for_loop.  They need
to share code instead.

Ughhhh, sorry about that.

Can you check the function comment in the new abstracted function
cp_parser_omp_for_loop_init()?  I'm not entirely sure what `real_decl'
and `for_block' are originally for, so I could use some help in
documenting them.

Otherwise, everything you pointed out I addressed.

How's this?



Attachment: curr
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]