This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] Fix for PR c/57490
- From: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- To: Jason Merrill <jason at redhat dot com>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: Jakub Jelinek <jakub at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Marek Polacek (polacek at redhat dot com)" <polacek at redhat dot com>
- Date: Mon, 19 Aug 2013 14:37:54 +0000
- Subject: RE: [PATCH] Fix for PR c/57490
- References: <BF230D13CA30DD48930C31D4099330003A43C80E at FMSMSX101 dot amr dot corp dot intel dot com> <20130701162401 dot GY2336 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A43C87D at FMSMSX101 dot amr dot corp dot intel dot com> <20130701170926 dot GB2336 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A43C8C0 at FMSMSX101 dot amr dot corp dot intel dot com> <yddhagcvwh0 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <ydda9ldisvi dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <yddtxizkrl0 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <BF230D13CA30DD48930C31D4099330003A458A6A at FMSMSX101 dot amr dot corp dot intel dot com> <520E6A65 dot 4010500 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A459B1F at FMSMSX101 dot amr dot corp dot intel dot com> <520F022F dot 20604 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A45A0C6 at FMSMSX101 dot amr dot corp dot intel dot com> <521222C4 dot 5080100 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A45A24A at FMSMSX101 dot amr dot corp dot intel dot com> <52122974 dot 2080606 at redhat dot com>
> -----Original Message-----
> From: Jason Merrill [mailto:jason@redhat.com]
> Sent: Monday, August 19, 2013 10:20 AM
> To: Iyer, Balaji V; Rainer Orth
> Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek
> (polacek@redhat.com)
> Subject: Re: [PATCH] Fix for PR c/57490
>
> On 08/19/2013 10:06 AM, Iyer, Balaji V wrote:
> > Well, it is described in cilkplus.def. The return type of it changes based on the
> array that is passed in. So, it is given a fake type. Thus, we need to fix it up here.
>
> Right, but it should be fixed up when the CALL_EXPR is created, rather than
> when that CALL_EXPR is used in another expression.
>
HI Jason,
I just want to make sure I get what you are saying. Are you suggesting that I do this in finish_call_expr() instead of cp_build_binary_op() ?
Thanks,
Balaji V. Iyer.
> Jason