This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,ARM] fix testsuite failures for arm-none-linux-gnueabihf


Hi Kyrylo

Thanks for the comments. I've done version 2 of the patch with the
changes incorporated



2013-08-16  Charles Baylis  <charles.baylis@linaro.org>

        * gcc.dg/builtin-apply2.c: skip test on arm hardfloat ABI targets
        * gcc.dg/tls/pr42894.c: Use -mfloat-abi=soft as Thumb1 does
not support hardfloat ABI
        * gcc,target/arm/thumb-ltu.c: Use -mfloat-abi=soft as Thumb1
does not support hardfloat ABI
        * lib/target-supports.exp
(check_effective_target_arm_fp16_ok_nocache): don't force
-mfloat-abi=soft when building for hardfloat target

On 15 August 2013 16:13, Kyrylo Tkachov <kyrylo.tkachov@arm.com> wrote:
> Hi Charles,
>
> CC'ing some of the ARM maintainers...
>
>> Hi
>>
>> The attached patch fixes some tests which fail when testing gcc for a
>> arm-none-linux-gnueabihf target because they do not expect to be built
>> with a hard float ABI.
>>
>> The change in target-supports.exp fixes arm-fp16-ops-5.c and arm-fp16-
>> ops-6.c.
>>
>> Tested on arm-none-linux-gnueabihf using qemu-arm, and does not cause
>> any other tests to break.
>>
>> Comments? This is my first patch, so please point out anything wrong.
>>
>
> --- gcc/testsuite/gcc.dg/tls/pr42894.c  (revision 201726)
> +++ gcc/testsuite/gcc.dg/tls/pr42894.c  (working copy)
> @@ -1,6 +1,7 @@
>  /* PR target/42894 */
>  /* { dg-do compile } */
>  /* { dg-options "-march=armv5te -mthumb" { target arm*-*-* } } */
> +/* { dg-options "-march=armv5te -mthumb -mfloat-abi=soft" { target arm*-*-*hf
> } } */
>  /* { dg-require-effective-target tls } */
>
> This test also fails for a bare-metal arm-none-eabi target configured with
> hard float, so perhaps this could be:
>
> -/* { dg-options "-march=armv5te -mthumb" { target arm*-*-* } } */
> +/* { dg-options "-march=armv5te -mthumb -mfloat-abi=soft" { target arm*-*-* }
> } */
>
>
>>
>>
>>
>> 2013-08-15  Charles Baylis  <charles.baylis@linaro.org>
>>
>>         * gcc.dg/builtin-apply2.c: skip test on arm hardfloat ABI targets
>>         * gcc.dg/tls/pr42894.c: Use -mfloat-abi=soft as Thumb1 does
>> not support hardfloat ABI
>>         * arm/thumb-ltu.c: Use -mfloat-abi=soft as Thumb1 does not
>> support hardfloat ABI
>
> ChangeLog entries are specified relative to the ChangeLog location. This
> should be:
>
>         * gcc.target/arm/thumb-ltu.c:...
>
>>         * target-supports.exp: don't force -mfloat-abi=soft when
>> building for hardfloat target
>
> Likewise, and also it's a good idea to specify which function/construct you're
> changing. In this case I think you're modifying
> check_effective_target_arm_fp16_ok_nocache. So this entry would be:
>
>         * lib/target-supports.exp
>         (check_effective_target_arm_fp16_ok_nocache):...
>
>
> Thanks,
> Kyrill
>
>
>
>

Attachment: hf-fixes2.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]