This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for PR c/57490


Hi Iyer,

>> thanks for the patch.  I've just bootstrapped it on i386-pc-solaris2.10
>> and all an-
>> if.c failures are gone.  That said, I wonder why we need the separate
>> pr57490.c
>> testcase, which is practically a preprocessed version of an-if.c with the
>> HAVE_IO
>> code removed.
>
> Well, it has assert in it. A while back someone (I think it was Jason
> Merrill, but I could be wrong) told me to replace all asserts with
> builtin_abort. But the content inside the file is the same.

in that case I'd suggest modifying an-if.c accordingly and not adding
pr57490.c.

>> I cannot approve the patch, though.
>
> OK. Can I ask why? Is it because you do not have an authority or is it
> because you see some errors (e.g. formatting errors) in it? If it is the
> latter, can you tell me what the errors are so that I can go and fix them?

It's simply not my area of authority.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]