This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix asan ICE with strlen instrumentation (PR sanitizer/56417)
- From: Dodji Seketeli <dodji at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 13 Aug 2013 13:14:43 +0200
- Subject: Re: [PATCH] Fix asan ICE with strlen instrumentation (PR sanitizer/56417)
- References: <20130813095313 dot GC1814 at tucnak dot redhat dot com>
Jakub Jelinek <jakub@redhat.com> writes:
> Hi!
>
> On the following (nonsensical) testcase we ICE because of pointer type
> mismatch. Fixed thusly, bootstrapped/regtested on x86_64-linux and
> i686-linux, ok for trunk/4.8?
>
> 2013-08-13 Jakub Jelinek <jakub@redhat.com>
>
> PR sanitizer/56417
> * asan.c (instrument_strlen_call): Fix typo in comment.
> Use char * type even for the lhs of POINTER_PLUS_EXPR.
>
> * gcc.dg/asan/pr56417.c: New test.
This looks OK to me.
Thanks for fixing this.
--
Dodji