This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64 gcc generate wrong assembly instruction movabs for intel syntax


Hello!

> movabs is incorrectly translated into "mov [rax], -1", and causes
> compile error "Error: ambiguous operand size for `mov' ".
> It should be "mov QWORD PTR [rax], -1"
>
> Bootstrap passed. Regression tested on x86_64-unknown-linux-gnu (pc).
>
> 2013-08-10  Perez Read <netfirewall@gmail.com>
>
>         * config/i386/i386.md (*movabs<mode>_1) :  Add <ptrsize> PTR before
>         operand 0 for intel asm alternative.
>
>         * testsuite/gcc.target/i386/movabs-1.c : New test.

You should mention PR number in the ChangeLog.

Looks OK, but I think that for consistency this decoration should also
be added to *movabs<mode>_2 pattern.

Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]