This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Regex back-reference support


On Sun, Aug 11, 2013 at 2:12 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> On 08/10/2013 06:04 PM, Paolo Carlini wrote:
>>
>> Also, in the new comment, you refer to a "stack", but in the same patch
>> you removed a std::stack and added a std::vector as data member, something
>> seems inconsistent.
>
> I had having a closer look to this: if one looks at the code now, without
> knowing that a std::stack was there probably the comment makes perfect
> sense, doesn't appear confusing (after all you are just using push_back and
> pop_back, and std::vector is fine for that).

I have to use a vector, because I need to iterate it while
manipulating it as a stack.


-- 
Tim Shen

Attachment: backref.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]