This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Enable non-complex math builtins from C99 for Bionic
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Alexander Ivchenko <aivchenk at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 9 Aug 2013 23:44:58 +0000
- Subject: Re: [PATCH] Enable non-complex math builtins from C99 for Bionic
- References: <CACysShg52_ah9oE2SLfb+yVk=eaQd+Z_cKOZTmz-vPfOrqiWrg at mail dot gmail dot com> <CAFiYyc0ed-OhT2_T94NidegWNPzUk5ezWR_9qHd2hedjKWh4Ug at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1211302115430 dot 10739 at digraph dot polyomino dot org dot uk> <CACysShjuePdWP1fDQ+=pbUQYjQDyzu3u1ypLfHsOf8-gjpDo5Q at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1212191754480 dot 3536 at digraph dot polyomino dot org dot uk> <CACysShhnjtoco63R1BsAPNiD=jB696e-1FOekC0f40YLFk9WrQ at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1301071615250 dot 23785 at digraph dot polyomino dot org dot uk> <CACysShhz+0gyscs-fkN7evVq1bGCMmgj09n6YQFAriKKn2C+HA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1307082206160 dot 7307 at digraph dot polyomino dot org dot uk> <CACysShhZkdphnWqy8qaCKotQEp7sYizsGi8ZJ0hg3wBTx7Xenw at mail dot gmail dot com>
On Sun, 28 Jul 2013, Alexander Ivchenko wrote:
> Hi Joseph, thanks for your comments.
> I updated the patch:
> 1) The function name as a second argument in libc_has_function target
> hook was removed - was not usefull so far.
> 2) By using contrib/config-list.mk (thanks for the hint - great tool!)
> and analysing tm.h files and what is included in them I have checked
> 197 targets. That analysis includes all issues that you raised in your
> comments - everything is fixed now. I don't like that sometimes we
> have to redefine the version of the hook back to the default one due
> to a poisoning of including elfos.h, but I couldn't find a better
> solution - I commented all those cases.
> Regtesting is in progress now. I have already tested the patch before,
> so I don't expect to see any new problems.
> If all the tests pass, is the patch OK for trunk?
This is OK, with function_gnu removed (nothing appears to use it), if no
OS port maintainers object to the changes for their OSes within the next
Joseph S. Myers