This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix for PR c/57490
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: "Iyer\, Balaji V" <balaji dot v dot iyer at intel dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, "gcc-patches\ at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Marek Polacek \(polacek\ at redhat dot com\)" <polacek at redhat dot com>
- Date: Fri, 09 Aug 2013 13:54:03 +0200
- Subject: Re: [PATCH] Fix for PR c/57490
- References: <BF230D13CA30DD48930C31D4099330003A43C80E at FMSMSX101 dot amr dot corp dot intel dot com> <20130701162401 dot GY2336 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A43C87D at FMSMSX101 dot amr dot corp dot intel dot com> <20130701170926 dot GB2336 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A43C8C0 at FMSMSX101 dot amr dot corp dot intel dot com> <yddhagcvwh0 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <ydda9ldisvi dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
>> "Iyer, Balaji V" <balaji.v.iyer@intel.com> writes:
>>
>>>> -----Original Message-----
>>>> From: Jakub Jelinek [mailto:jakub@redhat.com]
>>>> Sent: Monday, July 01, 2013 1:09 PM
>>>> To: Iyer, Balaji V
>>>> Cc: gcc-patches@gcc.gnu.org; Rainer Orth
>>>> Subject: Re: [PATCH] Fix for PR c/57490
>>>>
>>>> On Mon, Jul 01, 2013 at 05:02:57PM +0000, Iyer, Balaji V wrote:
>>>> > OK. The fixed patch is attached. Here are the ChangeLog entries:
>>>> >
>>>> > gcc/cp/ChangeLog
>>>> > 2013-07-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>>>> >
>>>>
>>>> Still
>>>> PR c/57490
>>>> hasn't been added to cp/ChangeLog and c/ChangeLog entries.
>>>> > --- /dev/null
>>>> > +++ b/gcc/testsuite/c-c++-common/cilk-plus/AN/pr57490.c
>>>> > @@ -0,0 +1,25 @@
>>>>
>>>
>>> Fixed as you suggested. Here is the fixed Changelogs and patch is attached.
>>>
>>> gcc/cp/ChangeLog
>>> 2013-07-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>>>
>>> PR c/57490
>>> * cp-array-notation.c (cp_expand_cond_array_notations): Added a
>>> check for truth values.
>>> (expand_array_notation_exprs): Added truth values case. Removed an
>>> unwanted else. Added for-loop to walk through subtrees in default
>>> case.
>>>
>>> gcc/c/ChangeLog
>>> 2013-07-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>>>
>>> PR c/57490
>>> * c-array-notation.c (fix_conditional_array_notations_1): Added a
>>> check for truth values.
>>> (expand_array_notation_exprs): Added truth values case. Removed an
>>> unwanted else. Added for-loop to walk through subtrees in default
>>> case.
>>>
>>>
>>> gcc/testsuite/ChangeLog
>>> 2013-07-01 Balaji V. Iyer <balaji.v.iyer@intel.com>
>>>
>>> PR c/57490
>>> * c-c++-common/cilk-plus/AN/pr57490.c: New test.
>>
>> I've just tested this patch on i386-pc-solaris2.10:
>>
>> The c-c++-common/cilk-plus/AN/an-if.c test still FAILs for C++:
>>
>> FAIL: c-c++-common/cilk-plus/AN/an-if.c -fcilkplus (internal compiler error)
>> FAIL: c-c++-common/cilk-plus/AN/an-if.c -fcilkplus (test for excess errors)
[...]
> This is still unfixed almost three weeks later. Balaji, could you
> please have a look?
This bug is now unfixed for two months, and no reaction whatsoever on
the report. This is getting annoying since it generates large amount of
testsuite noise.
Please fix ASAP!
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University