This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/Merge Request] Vtable Verification feature.


On Tue, Aug 6, 2013 at 10:35 AM, Caroline Tice <cmtice@google.com> wrote:
>
> choose_tmpdir(), from libiberty is not mentioned in any .h file, so cannot
> (at the moment) be used here.  Is it OK for me to add choose_tmpdir to
> libiberty.h?

Well, maybe.  But the approach looks a bit odd to me.  Also very
underdocumented--the -fvtv-counts option needs expanding.  And I don't
see why a user would ever invoke it anyhow, so perhaps it should be a
--param rather than a -f option.  The output to the file doesn't have
any indication of what file is being compiled, so it will be ambiguous
when run in parallel.  Why shouldn't this data be dumped into a
standard GCC dump file as we do with most data like this?  Your
sum-vtv-counts program could still work, it would just take a set of
dump files and look for the specific strings that it cares about.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]