Re: [PATCH/Merge Request] Vtable Verification feature.

[Caroline Tice <cmtice at google dot com>]

Second attempt.  The plain text patch file was too big, so I am
compressing it with gzip and trying again.

On Sat, Aug 3, 2013 at 8:29 AM, Caroline Tice <cmtice@google.com> wrote:
> Ok, I have done as you requested.  I am attaching the final patch for
> review. I did a bootstrap build and re-ran the regression test (still
> with no regression).  Below are the entries for the various ChangeLog
> files.  Is the ok to commit?
>
> -- Caroline Tice
> cmtice@google.com
>
>
> libstdc++-v3 ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         * fragment.am: Add XTEMPLATE_FLAGS.
>         * configure.ac: Add definitions for --enable-vtable-verify.
>         * acinclude.m4:  Add --enable-vtable-verify and
>         --disable-vtable-verify; define --enable-vtable-verify; define
>         VTV_CXXFLAGS, VTV_PCH_CXXFLAGS and VTV_CXXLINKFLAGS.
>         * config/abi/pre/gnu.ver: Export symbols for vtable verification.
>         * libsupc++/Makefile.am: Define vtv_sources and add it to
>         libsupc___la_SOURCES and libsupc__convenience_la_SOURCES.
>         * libsupc++/vtv_stubs.cc: New file.
>         * include/Makefile.am: Add VTV_PCH_CXXFLAGS to PCHFLAGS.
>         * src/Makefile.am: Add VTV_CXXFLAGS to AM_CXXFLAGS; add
>         VTV_CXXLINKFLAGS to CXXLINK.
>         * src/c++98/Makefile.am: Comment out XTEMPLATE_FLAGS; add VTV_CXXFLAGS
>         to AM_CXXFLAGS; add VTV_CXXXLINKFLAGS to CXXLINK.
>         * src/C++11/Makefile.am: Ditto.
>         * doc/xml/manual/configure.xml: Add entry for --enable-vtable-verify.
>         * scripts/testsuite_flags.in: Add cxxvtvflags to Usage; cause
>         cxxvtvflags to use VTV_CXXFLAGS and VTV_CXXLINKFLAGS.
>         * testsuite/lib/libstdc++.exp: Add cxxvtvflags; add code to locate
>         libvtv if --enable-vtable-verify was used; set cxxvtvflags; add
>         cxxvtvflags to cxx_final.
>         * testsuite/18_support/bad_exception/23591_thread-1.c: Add
>         -fvtable-verify=none to compiler flags.
>         * testsuite/17_intro/freestanding.cc: Add -fvtable-verify=none
>         to compiler flags.
>         * configure: Regenerated.
>         * Makefile.in: Regenerated.
>         * python/Makefile.in: Regenerated.
>         * include/Makefile.in: Regenerated.
>         * libsupc++/Makefile.in: Regenerated.
>         * config.h.in: Regenerated.
>         * po/Makefile.in: Regenerated.
>         * src/Makefile.in: Regenerated.
>         * src/c++98/Makefile.in: Regenerated.
>         * src/c++11/Makefile.in: Regenerated.
>         * doc/Makefile.in: Regenerated.
>         * testsuite/Makefile.in: Regenerated.
>
> top level ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         * configure.ac: Add target-libvtv to target_libraries; disable libvtv
>         on non-linux systems; add target-libvtv to noconfigdirs; add
>         libsupc++/.libs to C++ library search paths.
>         * configure: Regenerated.
>         * Makefile.def: Add libvtv to target_modules; make libvtv depend on
>         libstdc++ and libgcc.
>         * Makefile.in: Regenerated.
>
> include/ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         * vtv-change-permission.h: New file.
>
> contrib/ChangeLog:
> 2013-08-03  Caroline Tice4  <cmtice@google.com>
>
>         * gcc_update: Add libvtv files.
>
> libgcc/ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         config.host (extra_parts): Add vtv_start.o, vtv_end.o
>         vtv_start_preinit.o and vtv_end_preinit.o.
>         configure.ac: Add code to check/set enable_vtable_verify.
>         Makefile.in: Add rules to build vtv_*.o, if enable_vtable_verify is
>         true.
>         vtv_start_preinit.c: New file.
>         vtv_end_preinit.c: New file.
>         vtv_start.c: New file.
>         vtv_end.c: New file.
>         configure: Regenerated.
>
> gcc/ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         * gcc.c (VTABLE_VERIFICATION_SPEC): New definition.
>         (LINK_COMMAND_SPEC): Add VTABLE_VERIFICATION_SPEC.
>         * tree-pass.h: Add pass_vtable_verify.
>         * varasm.c (assemble_variable): Add code to properly set the comdat
>         section and name for the .vtable_map_vars section.
>         (assemble_vtyv_preinit_initializer): New function.
>         (default_sectin_type_flags):  Make sure .vtable_map_vars section has
>         LINK_ONCE flag.
>         * output.h: Add function decl for assemble_vtv_preinit_initializer.
>         * vtable-verify.c: New file.
>         * vtable-verify.h: New file.
>         * flag-types.h (enum vtv_priority): Defintions for flag_vtable_verify
>         initialiation levels.
>         * timevar.def (TV_VTABLE_VERIFICATION): New definition.
>         * passes.def: Insert pass_vtable_verify.
>         * aclocal.m4: Reorder includes.
>         * config/gnu-user.h (GNU_USER_TARGET_STARTFILE_SPEC): Add vtv_start*.o,
> as appropriate, if -fvtable-verify=... is used.
>         (GNU_USER_TARGET_ENDFILE_SPEC): Add vtv_end*.o as appropriate, if
>         -fvtable-verify=... is used.
>         * Makefile.in (OBJS):  Add vtable-verify.o to list.
>         (vtable-verify.o): Add new build rule.
>         (GTFILES): Add vtable-verify.c to list.
>         * common.opt (fvtable-verify=): New flag.
>         (vtv_priority): Values for fvtable-verify= flag.
>         (fvtv-counts): New flag.
> (fvtv-debug): New flag.
>         * tree.h (save_vtable_map_decl): New extern function decl.
>
>
> gcc/cp/ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         * Make-lang.in (*CXX_AND_OBJCXX_OBJS):  Add vtable-class-hierarchy.o to
>         list.
>         (vtable-class-hierarchy.o): Add build rule.
>         * cp-tree.h (vtv_start_verification_constructor_init_function): New
>         extern function decl.
>         (vtv_finish_verification_constructor_init_function): New extern
>         function decl.
>         (build_vtbl_address): New extern function decl.
>         (get_mangled_vtable_map_var_name): New extern function decl.
>         (vtv_compute_class_hierarchy_transitive_closure): New extern function
>         decl.
>         (vtv_generate_init_routine): New extern function decl.
>         (vtv_save_class_info): New extern function decl.
>         (vtv_recover_class_info): New extern function decl.
>         (vtv_build_vtable_verify_fndecl): New extern function decl.
>         * class.c (finish_struct_1): Add call to vtv_save_class_info if
>         flag_vtable_verify is true.
>         * config-lang.in: Add vtable-class-hierarchy.c to gtfiles list.
>         * vtable-class-hierarchy.c: New file.
>         * mangle.c (get_mangled_vtable_map_var_name):  New function.
>         * decl2.c (start_objects): Update function comment.
>         (cp_write_global_declarations): Call vtv_recover_class_info,
>         vtv_compute_class_hierarchy_transitive_closure and
>         vtv_build_vtable_verify_fndecl, before calling
>         finalize_compilation_unit, and call vtv_generate_init_rount after, IFF
>         flag_vtable_verify is true.
>         (vtv_start_verification_constructor_init_function): New function.
>         (vtv_finish_verification_constructor_init_function): New function.
>         * init.c (build_vtbl_address): Remove static qualifier from function.
>
> libvtv/ChangeLog:
> 2013-08-02  Caroline Tice  <cmtice@google.com>
>
>         Initial check-in of new vtable verification feature.
>         * configure.ac : New file.
>         * acinclude.m4 : New file.
>         * Makefile.am : New file.
>         * aclocal.m4 : New file.
>         * configure.tgt : New file.
>         * configure: New file (generated).
>         * Makefile.in: New file (generated).
>         * vtv_set.h : New file.
>         * vtv_utils.cc : New file.
>         * vtv_utils.h : New file.
>         * vtv_malloc.cc : New file.
>         * vtv_rts.cc : New file.
>         * vtv_malloc.h : New file.
>         * vtv_rts.h : New file.
>         * vtv_fail.cc : New file.
>         * vtv_fail.h : New file.
>         * vtv_map.h : New file.
>         * scripts/run-testsuite.sh : New file.
>         * scripts/sum-vtv-counts.c : New file.
>         * testsuite/parts-test-main.h : New file.
>         * testusite/dataentry.cc : New file.
>         * testsuite/temp_deriv.cc : New file.
>         * testsuite/register_pair.cc : New file.
>         * testsuite/virtual_inheritance.cc : New file.
>         * testsuite/field-test.cc : New file.
>         * testsuite/nested_vcall_test.cc : New file.
>         * testsuite/template-list-iostream.cc : New file.
>         * testsuite/register_pair_inserts.cc : New file.
>         * testsuite/register_pair_inserts_mt.cc : New file.
>         * testsuite/event.list : New file.
>         * testsuite/parts-test-extra-parts-views.cc : New file.
>         * testsuite/parts-test-extra-parts-views.h : New file.
>         * testsuite/environment-fail-32.s : New file.
>         * testsuite/parts-test-extra-parts.h : New file.
>         * testsuite/temp_deriv2.cc : New file.
>         * testsuite/dlopen_mt.cc : New file.
>         * testsuite/event.h : New file.
>         * testsuite/template-list.cc : New file.
>         * testsuite/replace-fail.cc : New file.
>         * testsuite/Makefile.am : New file.
>         * testsuite/Makefile.in: New file (generated).
>         * testsuite/mempool_negative.c : New file.
>         * testsuite/parts-test-main.cc : New file.
>         * testsuite/event-private.cc : New file.
>         * testsuite/thunk.cc : New file.
>         * testsuite/event-defintiions.cc : New file.
>         * testsuite/event-private.h : New file.
>         * testsuite/parts-test.list : New file.
>         * testusite/register_pair_mt.cc : New file.
>         * testsuite/povray-derived.cc : New file.
>         * testsuite/event-main.cc : New file.
>         * testsuite/environment.cc : New file.
>         * testsuite/template-list2.cc : New file.
>         * testsuite/thunk_vtable_map_attack.cc : New file.
>         * testsuite/parts-test-extra-parts.cc : New file.
>         * testsuite/environment-fail-64.s : New file.
>         * testsuite/dlopen.cc : New file.
>         * testsuite/so.cc : New file.
>         * testsuite/temp_deriv3.cc : New file.
>         * testsuite/const_vtable.cc : New file.
>         * testsuite/mempool_positive.c : New file.
>         * testsuite/dup_name.cc : New file.
>
> On Fri, Aug 2, 2013 at 11:20 AM, Diego Novillo <dnovillo@google.com> wrote:
>> On Thu, Aug 1, 2013 at 1:19 PM, Benjamin De Kosnik <bkoz@redhat.com> wrote:
>>
>>> You'll need a GWP to do the merge (Maybe Diego, Jason, Richard
>>> Henderson?) and then add yourself to MAINTAINERS for libvtv.
>>
>> Eh, no.  We need a GWP to approve the final patch, but Caroline can
>> and should do the merge herself.  The easiest approach is to generate
>> a patch on an svn checkout of trunk.  Caroline and I discussed this
>> earlier today.  It goes something like this (on a git client):
>>
>> $ git checkout -b vtv vtv
>> $ git merge origin/trunk
>> ... fix merge conflicts ...
>> $ git commit
>> $ git diff trunk >patch
>> ... Get rid of all the ChangeLog.vtv and configure diffs ...
>> ... Use git log to find the svn revision REV for the local trunk git tree ...
>> $ git co svn://gcc.gnu.org/gcc/trunk@REV
>> $ patch -p1 <patch
>> $ svn add ...new directories and files...
>>
>> At the end of this you'll have a checkout of trunk with the vtv
>> changes in.  You can now test it and send the final patch to the list
>> for a GWP to review.
>>
>>
>> Diego.

Attachment: gcc-fsf-final.vtv.diff.gz
Description: GNU Zip compressed data