This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Add builtin support for power8 32-bit Altivec multiply insns


On Thu, Aug 1, 2013 at 2:21 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
> This patch adds builtin support for the new 32-bit Altivec multiply
> instructions that were added in ISA 2.07 (ie, POWER8).
>
> This passed bootstrap and regtesting with no errors.  Ok for mainline?

Peter,

The builtins and patterns seem to be in a random order. Sometimes
signed is first and sometimes unsigned is first.  Please make the
ordering of the names consistent.

If these operations are multiplies, why are they described as UNSPEC
instead of MULT with SELECT?

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]