This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Fortran, PR 57987] Do not call cgraph_finalize_function multiple times on finalizers
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, fortran at gcc dot gnu dot org, Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 2 Aug 2013 13:01:54 +0200
- Subject: Re: [PATCH, Fortran, PR 57987] Do not call cgraph_finalize_function multiple times on finalizers
- References: <20130802100821 dot GD2728 at virgil dot suse>
> Hi,
>
> when looking at another PR, I found out that inliner refused to even
> consider __final_test2_T/0 because, according to the dump, "redefined
> extern inline functions are not considered for inlining." When I
> looked at why, I realized that the function is "finalized" (by
> cgraph_finalize_function) twice. Once directly from front-end and
> second time from un-nesting nested functions.
>
> This patch makes sure that the Fortran front-end does not do that.
> Some details about the patch development over the time is in bugzilla.
> Bootstrapped and tested on x86_64-linux without any problems, OK for
> trunk?
OK (I hope that the fortran part is cgraph centric so I can approve it), thanks.
Thanks for noticing it - those missed inlines seems quite unforutnate.
Honza