This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Do not use PARM_DECLs in ipa-cp and ipa-prop
- From: Martin Jambor <mjambor at suse dot cz>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 1 Aug 2013 17:36:27 +0200
- Subject: Re: Do not use PARM_DECLs in ipa-cp and ipa-prop
- References: <20130801131135 dot GB22179 at kam dot mff dot cuni dot cz>
Hi,
On Thu, Aug 01, 2013 at 03:11:36PM +0200, Jan Hubicka wrote:
> Hi,
> this is preparation work to move DECL_ARGUMENTS and DECL_RESULT into function
> sections during WPA. Even with some work to release unused ones, there are 4M
> of PARM_DECLs and 2M of RESULT_DECLs streamed during LTO (for 6M of
> function_decls) making them one of the most common nodes.
>
> This patch makes ipa-cp and ipa-prop to not use DECL_ARGUMENTS during WPA
> stage. this only needed to tamn debug info, move logic doing casts from
> get_replacement_map to tree_function_versioning and stream move_cost that is
> computed form parm type.
>
> Martin, does this patch look OK?
>
Generally yes, except that I think you did not convert some dumping in
ipa-cp.c, at least in functions estimate_local_effects,
find_more_scalar_values_for_callers_subset and decide_about_value. I
believe that after your change there should not be a single call to
ipa_get_param in file ipa-cp.c.
Thanks,
Martin