This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Trevor Saunders <tsaunders at mozilla dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 31 Jul 2013 22:02:29 -0500
- Subject: Re: [PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it
- References: <1375319690-12939-1-git-send-email-tsaunders at mozilla dot com> <1375319690-12939-2-git-send-email-tsaunders at mozilla dot com>
On Wed, Jul 31, 2013 at 8:14 PM, Trevor Saunders <email@example.com> wrote:
> bootstrapped and same test results on x86_64-linux-gnu against r201084
> * cxx-pretty-print.h (cxx_pretty_printer): inherit from c_pretty_printer
> instead of include it.
> * (cxx_pretty_print.c): adjust accordingly.
This is on my todo stack; thanks for looking into it.
The way to handle this is:
* yes, use inheritance -- that is what I simulated with the C abstractions
* declare the "pointer to function fields" as virtual functions --
that is what I meant
with the (necessarily poor) emulation through the casts.
* override those that needed to be overridden in cxx_pretty_printer.
* adjust the macros.
* Have the associated constructors do the right thing.