This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Refractor Thompson matcher


On 07/31/2013 01:11 AM, Tim Shen wrote:
On Wed, Jul 31, 2013 at 7:03 AM, Paolo Carlini <> wrote:
Did you actually bootstrap & test the patch? Because you didn't last time,
I compiled it and run the 28_regex testsuite, nothing wrong happened
because there're all single-file testcases in it;
but I ignored the duplicated definition problem. It'll never happen in
the future. Sorry again.
Earlier, even without bootstrapping you should have noticed that the library didn't build. It's not about excuses, it's about following a policy, which, should be obvious now, we are following for a reason: all posted patches must be boostrapped & tested.
Please add FIXME comments to all the non-template functions in *.tcc files
(which will be moved to *.cc files). To repeat: the inlines in *.tcc files
must be all and only non-templates, as a temporary hack.
Please post the complete patch you intend to commit. Part of the GCC policy is also that all the patches must be posted complete, exactly as would be committed upon approval.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]