This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Google] Fix profiledbootstrap failure
- From: Xinliang David Li <davidxl at google dot com>
- To: Teresa Johnson <tejohnson at google dot com>
- Cc: Dinar Temirbulatov <dinar at kugelworks dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Rong Xu <xur at google dot com>
- Date: Tue, 30 Jul 2013 12:02:18 -0700
- Subject: Re: [Google] Fix profiledbootstrap failure
- References: <CANoaTN1kr2-Zu48Puq8rVRj_oEjUVPinDXeVo+ohmY-Kch3abg at mail dot gmail dot com> <CAAe5K+W6wJLPUbJSmrZbAp+Og6kc6dcWuHiwh-WONFq4voogHw at mail dot gmail dot com>
I need to understand why this affects profile bootstrap -- is this due
to file name conflict?
The fix is wrong -- please do not remove the parameter. If it is a
problem, a better fix is to change the default parameter value to 0.
David
On Tue, Jul 30, 2013 at 11:56 AM, Teresa Johnson <tejohnson@google.com> wrote:
> cc'ing Rong and David since this came from LIPO support.
>
> The patch as-is removes the one use of PARAM_GCOV_DEBUG (which is on
> by default) without removing the parameter itself. What is the failure
> mode you see from this code?
>
> Thanks,
> Teresa
>
> On Tue, Jul 30, 2013 at 11:50 AM, Dinar Temirbulatov
> <dinar@kugelworks.com> wrote:
>> Hello
>>
>> This change allows to complete profiledbootstrap on the google gcc-4.8
>> branch, tested with make bootstrap with no new regressions. OK for
>> google 4.8?
>> thanks, Dinar.
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413