This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C, C++] Implement -Wstatic-local
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Jul 2013 12:51:55 -0700
- Subject: Re: [C, C++] Implement -Wstatic-local
- References: <51EEDDF2 dot 9010001 at redhat dot com>
On Tue, Jul 23, 2013 at 12:48 PM, Florian Weimer <fweimer@redhat.com> wrote:
> We sometimes deal with code bases which use static local variables to cut
> down frame size, for compatibility with legacy targets. Obviously, this is
> bad for thread safety. This new warning can be used to track down such
> cases once you suspect they exist.
Hmm, since you mentioned bad for thread safety but then I see in your
patch you don't check to see if the variable is a thread local
variable. Maybe you should not mention thread safety at all here or
change the code not to include TLS variables.
Thanks,
Andrew
>
> Bootstrapped and regression-tested on x86_64-redhat-linux-gnu. Okay for
> trunk?
>
> --
> Florian Weimer / Red Hat Product Security Team
>