This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Reimplment regex matcher using DFS

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 23 Jul 2013 15:42:07 +0200
Subject: Re: [Patch] Reimplment regex matcher using DFS
References: <CAPrifDnky=cuvwL0HHCKD5zOkLj5EqFbBm9-HXSyEXYjNUKzMg at mail dot gmail dot com>

On 07/23/2013 03:07 PM, Tim Shen wrote:

+  inline
+  bool _Grep_matcher::
+  _M_dfs_match()
+  { return _M_dfs<true>(_M_nfa->_M_start()); }
+
+  inline
+  bool _Grep_matcher::
+  _M_dfs_search_from_first()
+  { return _M_dfs<false>(_M_nfa->_M_start()); }

This doesn't make much sense to me: if the functions are inside a *.tccfile why are marked inline? First blush seem indeed good candidates forinline, but then should be in the *.h


Paolo.

Follow-Ups:
- Re: [Patch] Reimplment regex matcher using DFS
  - From: Paolo Carlini
- Re: [Patch] Reimplment regex matcher using DFS
  - From: Tim Shen

References:
- [Patch] Reimplment regex matcher using DFS
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]