This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] regex_iterator and regex_token_iterator implementation


On 23 July 2013 10:18, Tim Shen wrote:
>
> Are other parts ok? Could you please look at them?

In regex_token_iterator::_M_init the for loop could be replaced with
either for (auto __i : subs) or a call to std::find, which wouldn't
need the cast to int, but that's just stylistic and a matter of taste.

With the uglified names restored the patch is good to commit, thanks very much.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]