This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] regex_iterator and regex_token_iterator implementation
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Jul 2013 12:48:12 +0100
- Subject: Re: [Patch] regex_iterator and regex_token_iterator implementation
- References: <CAPrifDm07qvEoJEC9BBkRa1yuCrM9vXRoDPTXfJEjfVmj=XKNQ at mail dot gmail dot com> <51EC86EE dot 20004 at oracle dot com> <CAPrifDk8Ur4m3P+Jr-sb231LvWzBPoWFA83hNMRsM5zgP9J0eA at mail dot gmail dot com> <CAH6eHdRFvZYkfwZdnSaaj5yOmSceKoTXnf_8zOQx-izXFNGyNw at mail dot gmail dot com> <CAPrifD=k6vjq=acHZbYbocUvR+85v6yRJwHuEi=SwEiHo72MrA at mail dot gmail dot com>
On 23 July 2013 10:18, Tim Shen wrote:
>
> Are other parts ok? Could you please look at them?
In regex_token_iterator::_M_init the for loop could be replaced with
either for (auto __i : subs) or a call to std::find, which wouldn't
need the cast to int, but that's just stylistic and a matter of taste.
With the uglified names restored the patch is good to commit, thanks very much.