This is the mail archive of the
mailing list for the GCC project.
Re: [v3] libstdc++/57920
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Chung-Ju Wu <jasonwucj at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 23 Jul 2013 11:26:24 +0200
- Subject: Re: [v3] libstdc++/57920
- References: <51ED2095 dot 9000403 at oracle dot com> <CADj25HPZQNgAMm4abc3_c6-vM22U4hCMWW6Q_-Dk0iKFvQ0EPg at mail dot gmail dot com>
On 07/23/2013 11:17 AM, Chung-Ju Wu wrote:
The issue is theoretical at the moment because <string> ends up
including <cstdio> anyway, thus the above can't really happen. It's true
that the above union - which by way I didn't invent - it's rather
annoying if we manage to *really* avoid including <cstdio>, which is
2013/7/22 Paolo Carlini <email@example.com>:
see audit trail for details. I tested on x86_64-linux (with/without
_GLIBCXX_X86_RDRAND artificially undefined) the below straightforward patch
and checked by hand the strace. I'm going to apply it soon.
1641 FILE* _M_file;
1642 mt19937 _M_mt;
causing the following error:
libstdc++-v3/include/bits/random.h:1641:5: error: 'FILE' does not name a type
Perhaps cstdio is necessary in this case. What do you think? :-)
Currently you can't really get the error above.