This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, PR57803] Wasted work in gfc_build_dummy_array_decl()

From: Jeff Law <law at redhat dot com>
To: pchang9 at cs dot wisc dot edu
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
Date: Mon, 22 Jul 2013 09:22:57 -0600
Subject: Re: [Patch, PR57803] Wasted work in gfc_build_dummy_array_decl()
References: <3b98e0fc39b803e4611dad05371309f7 dot squirrel at webmail dot cs dot wisc dot edu>

On 07/19/2013 04:59 PM, pchang9@cs.wisc.edu wrote:

Hi,

The problem appears in revision 201034 in version 4.9.  I attached a
one-line patch that fixes it.  I also reported this problem
at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57803

I bootstrapped and ran the regression tests for this patch on x86_64-linux
and all tests pass.

In method "gfc_build_dummy_array_decl()" in gcc/fortran/trans-decl.c,
the loop on line 978 should break immediately after "packed" is set to
"PACKED_PARTIAL". All the iterations after "packed" set to
"PACKED_PARTIAL" do not perform any useful work, at best they just set
"packed" again to "PACKED_PARTIAL".

Thanks. I've installed the patches from all of your emails whichaddress these issues.

I'm a bit curious, are you finding these by inspection of the sources orvia some kind of analysis code?


Thanks again,
Jeff

References:
- [Patch, PR57803] Wasted work in gfc_build_dummy_array_decl()
  - From: pchang9

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]