This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix pr57637
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Zhenqiang Chen <zhenqiang dot chen at linaro dot org>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Earnshaw <rearnsha at arm dot com>
- Date: Mon, 22 Jul 2013 11:56:42 +0200
- Subject: Re: [PATCH] Fix pr57637
- References: <CACgzC7Cab2ke3L0AqGUvqdxg-PEf2r-xkwHq=OYu4UviEhyw6g at mail dot gmail dot com> <17842494 dot JlJor7ihF6 at polaris> <CACgzC7DVCmA4U3V_jhMyw7GYWTzdCgNp0EqcEtWYTn1dqNh3TA at mail dot gmail dot com>
> The patch is updated based the comments: it will check GEN set of LIVE
> if df_live exists. Otherwise, just give up.
The patch is missing a ChangeLog. Otherwise it looks good, modulo:
+ /* DF_LR_BB_INFO (bb)->def does not kill the DF_REF_PARTIAL and
+ DF_REF_CONDITIONAL defs. So if DF_LIVE doesn't exist, i.e.
"does not comprise"
+ at -O1, just give up to search NEXT_BLOCK
"just give up searching"
I'm not sure this matters in practice, but don't we need to set the appropriate
bit in the GEN set of BB at the end of the function if df_live is non-zero, at
least for the sake of consistency?
> And a testcase is included in the attached patch.
Thanks. We generally try to make the testcases self-contained, i.e. remove the
#include's as much as possible. It seems that stdlib.h is included for abort;
if so, remove it and use __builtin_abort instead. Would it be possible to
remove stdio.h as well?