This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] regex_iterator and regex_token_iterator implementation


On 07/22/2013 02:47 AM, Tim Shen wrote:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57513 is already in the
testsuite and can passed(even before this patch?).

To fully test it, a fully regex_search implementation is required. I'm
working on a (damning) backtracking engine for it.
A couple of comments on the patch: the operator++, operator=, operator==, and _M_init are definitely too big to be inline. Also you are wrongly "un-uglyfying" many names, eg:

-      position_iterator __position;
-      const value_type* __result;
-      value_type        __suffix;
-      std::size_t       __n;
-      std::vector<int>  __subs;


Remember all the names must begin by double underscore or single underscore, etc.

Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]