This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Partially implement regex_search
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 22 Jul 2013 02:13:51 +0200
- Subject: Re: [Patch] Partially implement regex_search
- References: <CAPrifDkbxOwi2V6PTZrJEG8gA-H1EPgC2T+J08YqOKmY-P=Ocw at mail dot gmail dot com> <CAH6eHdSLHsPk5g1e=un3NJo+7Mhv37GrEwq0A2GKKRjB7DLyug at mail dot gmail dot com> <CAPrifDme_ateOVYrbdP++WakHYP4apPwB+Tsq38OWEFYUTfJKw at mail dot gmail dot com> <CAH6eHdTtpxFYwevbn+inYhGPxTq_jdmM=JvsoC_U__ryzvOaMw at mail dot gmail dot com> <CAPrifDmSjct=t_BH1To-KVGqw5D4dNHuEW0sQZsZQLb+p_9yGg at mail dot gmail dot com>
-- Tim,
while you work on these improvements, I think it would nice to also
commit, when appropriate, testcases which came with bug reports which we
closed as duplicates of the "std::regex is not implemented yet" report.
I'm not referring to this specific commit, just a general comment.
Thanks,
Paolo.