This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/*] Fix common typos.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sun, 21 Jul 2013 19:02:34 +0200
- Subject: Re: [PATCH 1/*] Fix common typos.
- References: <20130721143204 dot GA27788 at domone> <alpine dot DEB dot 2 dot 10 dot 1307211639090 dot 4003 at laptop-mg dot saclay dot inria dot fr>
On Sun, Jul 21, 2013 at 04:44:40PM +0200, Marc Glisse wrote:
> On Sun, 21 Jul 2013, OndÅej BÃlka wrote:
>
> >Then I ran script/stylepp_fix_spell which produced following 300kb patch:
> >
> >http://kam.mff.cuni.cz/~ondra/0001-Fix-common-typos.patch
>
> There are still some wrong fixes, humans really need to check each
> of them (for instance throught -> thought instead of through). I
> think I saw a few overlong lines (more than 80 chars on a line,
> counting a tab as 8) after replacement.
I try to keep these issues separate.
Dealing with long lines is one of these. Now I added another tool to
stylepp. If you add stylepp/script to PATH then you can run
stylepp_long_line --hook
Which will open vim on lines with long lines. A hook flag is for
opening only files that were changed since last commit (only git for now).
> I don't know if capitalizing
> all instances of "ok" is really worth it...
>
Well both are valid, according to wikipedia OK is better because it ok
is harder to spot when you glance through code.
http://en.wikipedia.org/wiki/Okay
Problem here is not ok itself but that diffs in patch are organized in
mostly random order. If I could sort hunks such that typos come in
alphabetic order it would be easier to review repeated corrections.
I am not sure how to get this.
> --
> Marc Glisse