This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/*] Fix common typos.


On Sun, Jul 21, 2013 at 05:37:23PM +0200, Marek Polacek wrote:
> 
> A few comments:
> 
snip
> diff --git a/gcc/ipa.c b/gcc/ipa.c
> index 7c0d495..d44cf38 100644
> --- a/gcc/ipa.c
> +++ b/gcc/ipa.c
> @@ -548,7 +548,7 @@ static bool
>  comdat_can_be_unshared_p_1 (symtab_node node)
>  {
>    /* When address is taken, we don't know if equality comparison won't
> -     break eventaully. Exception are virutal functions and vtables, where
> +     break eventaully. Exception are virtual functions and vtables, where
> 
> "eventually"
>
It is new misspell so it should not be part of this patch but next one.
When you encounter them could you write list with form:

eventaully eventually 
...

to make integration easier?

> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index 2787d67..b0dad7d 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,64 @@
> +2013-07-21   OndÃÂej BÃÂlka  <neleai@seznam.cz>
> +
> +	* c-c++-common/pr41779.c: Fix typos.
> +	* c-c++-common/raw-string-13.c: Likewise.
> +	* c-c++-common/raw-string-14.c: Likewise.
> +	* c-c++-common/raw-string-15.c: Likewise.
> +	* c-c++-common/raw-string-16.c: Likewise.
> +	* c-c++-common/raw-string-2.c: Likewise.
> +	* ChangeLog: Likewise.
> 
> ChangeLog in a ChangeLog?
>
yeah, I ran generating script with previous commit so it was wrong. 

> diff --git a/libsanitizer/ChangeLog b/libsanitizer/ChangeLog
> index d2c80b3..a6c7d5f 100644
> --- a/libsanitizer/ChangeLog
> +++ b/libsanitizer/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-07-21   OndÃÂej BÃÂlka  <neleai@seznam.cz>
> +
> +	* tsan/tsan_interface_atomic.cc: Fix typos.
> 
> I don't think we should make changes to libsanitizer/*.
>

On Sun, Jul 21, 2013 at 04:32:04PM +0200, OndÅej BÃlka wrote:
>> Now I exclude those directories that are upstream, see file
>> https://github.com/neleai/stylepp/blob/master/maintained/gcc/ignore
>> and if you want ignore additional files/directories add them to this
>> file.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]