This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix raw-string handling (PR preprocessor/57620)
- From: Jason Merrill <jason at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 18 Jul 2013 12:29:25 -0400
- Subject: Re: [PATCH] Fix raw-string handling (PR preprocessor/57620)
- References: <20130617162846 dot GB2336 at tucnak dot redhat dot com> <51DCFDC0 dot 3080703 at redhat dot com> <20130710233258 dot GJ2475 at laptop dot redhat dot com> <20130711052327 dot GK2475 at laptop dot redhat dot com>
Hmm, that logic is difficult to follow. It needs comments at least
explaining last_seen_* and why the loop in the suffix handling keeps
going after we change the phase to RAW_STR.
Maybe instead of tracking last_seen_* BUFF_APPEND could copy into a
short local char array as well as the string buffer?
Jason