This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Partially implement regex_search
- From: Tim Shen <timshen91 at gmail dot com>
- To: Jonathan Wakely <jwakely dot gcc at gmail dot com>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 18 Jul 2013 18:06:14 +0800
- Subject: Re: [Patch] Partially implement regex_search
- References: <CAPrifDkbxOwi2V6PTZrJEG8gA-H1EPgC2T+J08YqOKmY-P=Ocw at mail dot gmail dot com> <CAH6eHdSLHsPk5g1e=un3NJo+7Mhv37GrEwq0A2GKKRjB7DLyug at mail dot gmail dot com>
On Wed, Jul 17, 2013 at 7:06 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> The changelog has a typo, _M__search_from_first has two underscores.
>
> The testcase dg-options should use -std=gnu++11 not -std=c++0x. Is
> the testcase based on an existing file? If not the copyright year
> should just be 2013.
These will be fixed when commit to SVN.
By the way, this implementation is not necessarily the ultimate one.
It's simple and don't require NFA modification.
For efficiency purpose in the future, a
"some_re".search() => ".*(some_re).*".match()
algorithm should be used(at least for Thompson NFA).
--
Tim Shen