This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Partially implement regex_search


On 17 July 2013 11:26, Tim Shen wrote:
> A simple enumerating-first-position approach.

Thanks for the new patch.  A couple of quick comments before I review
it properly:

The changelog has a typo, _M__search_from_first has two underscores.

The testcase dg-options should use -std=gnu++11 not -std=c++0x.  Is
the testcase based on an existing file? If not the copyright year
should just be 2013.

I'll review the actual code parts later, thanks again.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]