This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: David Edelsohn <dje dot gcc at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>, Pat Haugen <pthaugen at us dot ibm dot com>
- Date: Mon, 15 Jul 2013 14:46:56 -0500
- Subject: Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- References: <1372734758 dot 4736 dot 149 dot camel at otta> <CAGWvny=8o0CUt7u03S_ueL7x3z66QG0LHfhf-PotTTEmPBdkHg at mail dot gmail dot com> <1373901800 dot 4538 dot 122 dot camel at otta> <CAGWvnynhLzpgwBN7+NH3krzc3NubvPenBvnhUMgnU1WPkr-rHA at mail dot gmail dot com> <1373909158 dot 4538 dot 156 dot camel at otta> <20130715184412 dot GN2475 at laptop dot redhat dot com> <20130715191359 dot GQ2475 at laptop dot redhat dot com>
On Mon, 2013-07-15 at 21:13 +0200, Jakub Jelinek wrote:
> > Looking at the patch, you've changed FIRST_PSEUDO_REGISTER (internal gcc
> > thing, so fine), but that also changed DWARF_FRAME_REGISTER which was
> > computed based on FIRST_PSEUDO_REGISTER. Isn't that an ABI break in the
> > unwinder (think about having parts of unwinder linked from different
> > versions of libgcc)?
> > Can't we just tweak DWARF_FRAME_REGISTER not to include those registers?
Thanks for noticing this.
> I'd say something like (but, untested and can't test it right now (and no
> access to power8 anyway)):
Do we also need to update DWARF_REG_TO_UNWIND_COLUMN similarly, which
also uses FIRST_PSEUDO_REGISTER when the dwarf reg is an SPE synthetic
register? Or should we just break the dependence on FIRST_PSEUDO_REGISTER
altogether so this type of thing doesn't happen again? Otherwise, we
should place a comment at the definition of FIRST_PSEUDO_REGISTER
warning of it's use in DWARF_FRAME_REGISTER.
Peter
- References:
- [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power
- Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power