This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.


On 13/07/2013, at 10:34 AM, Mike Stump wrote:

> On Jun 20, 2013, at 4:30 AM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>> for Android:
> 
>> +2013-06-19  Alexander Ivchenko  <alexander.ivchenko@intel.com>
>> +
>> +       * g++.dg/tls/thread_local4.C: Disable test for Android.
>> +       * g++.dg/tls/thread_local4g.C: Ditto.
> 
>> is it ok for trunk?
> 
> Ok.

Alexander,

Your current patch as approved by Mike is OK, but it is more prudent to condition the tests on using Bionic libc, not the fact that target triplet has *-android* in it.  [E.g., it is possible to build a toolchain for, say, arm-linux-gnueabi which will use glibc for primary multilib, and bionic for secondary multilib.]

I didn't test the attached patch, so please confirm that it behaves as expected before applying it.

Thank you,

--
Maxim Kuvyrkov
KugelWorks

Attachment: 0001-Disable-tests-that-require-cancellation-when-using-B.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]