This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Fix c/57821


On Thu, 4 Jul 2013, Joern Rennecke wrote:

> Quoting "Joseph S. Myers" <joseph@codesourcery.com>:
> 
> > On Thu, 4 Jul 2013, Joern Rennecke wrote:
> > 
> > > For this fix I've assumed that it is now the job of the various places
> > > that
> > > do calculations with sizetypes to flag overflows where this is desired.
> > 
> > Integer constants may be shared, I don't think setting TREE_OVERFLOW on
> > existing constants like you do is necessarily safe.
> 
> Hmm, indeed.  I now added a copy_node call in set_init_index to avoid this
> problem.  For complete_array_type, we need this information just a bit
> further thon in the function, so I just made it a boolean flag.
> 
> > Also note c/ and c-family/ have their own ChangeLog files.
> 
> Oops. I though I checked that.  Foiled by ls localisation.
> 
> I'm currently testing the attached updated patch.

This is OK if it passes testing.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]