This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,i386] Cannot inline sse*.* functions into avx functions
- From: Sriraman Tallam <tmsriram at google dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, David Li <davidxl at google dot com>, Rong Xu <xur at google dot com>
- Date: Tue, 2 Jul 2013 17:03:44 -0700
- Subject: Re: [patch,i386] Cannot inline sse*.* functions into avx functions
- References: <CAAs8HmywEfzR3CxOUQSQ3z1LC2xvucR--acW0e3Bavy0jO9J1w at mail dot gmail dot com> <CAFULd4aX_Vz=rmMc2yfpu73rPJUY3+kWN-GxNWp5_D-sxiXovg at mail dot gmail dot com> <20130630094328 dot GB1611 at kam dot mff dot cuni dot cz> <20130630094711 dot GA29983 at kam dot mff dot cuni dot cz> <CAFULd4ZfePvrwz0NyHudvV+p7qi14m2pwntQwS_2fQJeR3ZQiw at mail dot gmail dot com> <CAAs8Hmx7-oKu4WhQzv4QcQBV2_mgc8ZyyWVbguB9G7SdCYBzAA at mail dot gmail dot com> <CAFULd4aTg0m9JqQ00=PRkcv2O3aNMZh4SRUdJdp-OfiYWUZtow at mail dot gmail dot com>
On Mon, Jul 1, 2013 at 2:12 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Mon, Jul 1, 2013 at 8:01 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>
>> So, something like the patch attached?
>>
>> * config/i386/i386.c (ix86_option_override_internal): Turn
>> on all -mavx target flags by default as they are dependent
>> on AVX anyway.
>
> Yes, but please also add:
>
> Index: i386.c
> ===================================================================
> --- i386.c (revision 200579)
> +++ i386.c (working copy)
> @@ -2578,7 +2578,7 @@ static const char *const cpu_names[TARGET_CPU_DEFA
> static bool
> gate_insert_vzeroupper (void)
> {
> - return TARGET_VZEROUPPER;
> + return TARGET_AVX && TARGET_VZEROUPPER;
> }
>
> static unsigned int
>
> so we won't trigger vzeroupper insertion pass for non-AVX targets.
Made that change, added the test case and committed.
Thanks
Sri
>
> Uros.