RE: [PATCH] Fix for PR c/57490

["Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>]

> -----Original Message-----
> From: Jakub Jelinek [mailto:jakub@redhat.com]
> Sent: Monday, July 01, 2013 12:24 PM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org; Rainer Orth
> Subject: Re: [PATCH] Fix for PR c/57490
> 
> On Mon, Jul 01, 2013 at 04:17:37PM +0000, Iyer, Balaji V wrote:
> > gcc/c/ChangeLog
> > +2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > +
> 
> The PR c/57490 line belongs to all ChangeLog entries related to the fix, not
> just testsuite.
> 
> > +       * c-array-notation.c (fix_conditional_array_notations_1): Added a
> > +       check for truth values.
> > +       (expand_array_notation_exprs): Added truth values case.  Removed an
> > +       unwanted else.  Added for-loop to walk through subtrees in default
> > +       case.
> > +
> >
> > gcc/cp/ChangeLog
> > +2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > +
> > +       * cp-array-notation.c (cp_expand_cond_array_notations): Added a
> > +       check for truth values.
> > +       (expand_array_notation_exprs): Added truth values case.  Removed an
> > +       unwanted else.  Added for-loop to walk through subtrees in default
> > +       case.
> 
> I'll leave this to C/C++ maintainers.
> 
> > gcc/testsuite/ChangeLog
> > +2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > +
> > +       PR c/57490
> > +       * c-c++-common/cilk-plus/AN/pr57490.i: New test.
> > +       * gcc.dg/cilk-plus/cilk-plus.exp: Added compilation of .i files.
> 
> Ugh, no.  Please add the test as *.c test instead, and strip all the
> unneeded garbage from it.  It would surprise me a lot if the # line ...,
> #pragma ident or blank lines were required to reproduce the problem.

OK. The fixed patch is attached. Here are the ChangeLog entries:

gcc/cp/ChangeLog
2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        * cp-array-notation.c (cp_expand_cond_array_notations): Added a
        check for truth values.
        (expand_array_notation_exprs): Added truth values case.  Removed an
        unwanted else.  Added for-loop to walk through subtrees in default
        case.

gcc/c/ChangeLog
2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        * c-array-notation.c (fix_conditional_array_notations_1): Added a
        check for truth values.
        (expand_array_notation_exprs): Added truth values case.  Removed an
        unwanted else.  Added for-loop to walk through subtrees in default
        case.

gcc/testsuite/ChangeLog
2013-07-01  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        PR c/57490
        * c-c++-common/cilk-plus/AN/pr57490.c: New test.


> 
> 	Jakub

Attachment: pr57490.txt
Description: pr57490.txt