This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, mips] Fix for PR target/56942


(Top post is gmail's fault ;-)

Hello,

I dont like this at all.      At the very least, if we go this way,
then all places where next_active_insn is used should be updated.
Otherwise this is just confusion proliferation. Before my patch most
ports used the "active" variants and I specifically did non fix the
"real" variants. It is marked fixme for a reason: The JUMP_TABLE_DATA
should always follow immediately after the label. Copying the fixme is
a step in the wrong direction. Please do not commit this patch!

Ciao!
Steven



On 4/30/13, Richard Sandiford <rdsandiford@googlemail.com> wrote:
> Steve Ellcey <sellcey@imgtec.com> writes:
>> OK, here is patch to next_real_insn to keep the ordering property intact
>> and fix the bug.  OK for checkin?
>
> Thanks, looks good to me, but an rtl/middle-end/global maintainer
> would need to approve it.
>
> Richard
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]