This is the mail archive of the
mailing list for the GCC project.
Re: [patch, mips] Fix for PR target/56942
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Steve Ellcey <sellcey at imgtec dot com>, gcc-patches at gcc dot gnu dot org, andrew dot bennett at imgtec dot com, stevenb dot gcc at gmail dot com, rdsandiford at googlemail dot com
- Date: Tue, 30 Apr 2013 13:46:27 +0200
- Subject: Re: [patch, mips] Fix for PR target/56942
- References: <2c243f55-9b58-4e4a-86cf-9dd5be8ea183 at BAMAIL02 dot ba dot imgtec dot org> <87sj2gifze dot fsf at talisman dot default> <1367016105 dot 1650 dot 43 dot camel at ubuntu-sellcey> <87ehdwiezi dot fsf at talisman dot default> <1367266413 dot 8625 dot 3 dot camel at ubuntu-sellcey> <87mwsgh5eb dot fsf at talisman dot default>
(Top post is gmail's fault ;-)
I dont like this at all. At the very least, if we go this way,
then all places where next_active_insn is used should be updated.
Otherwise this is just confusion proliferation. Before my patch most
ports used the "active" variants and I specifically did non fix the
"real" variants. It is marked fixme for a reason: The JUMP_TABLE_DATA
should always follow immediately after the label. Copying the fixme is
a step in the wrong direction. Please do not commit this patch!
On 4/30/13, Richard Sandiford <firstname.lastname@example.org> wrote:
> Steve Ellcey <email@example.com> writes:
>> OK, here is patch to next_real_insn to keep the ordering property intact
>> and fix the bug. OK for checkin?
> Thanks, looks good to me, but an rtl/middle-end/global maintainer
> would need to approve it.