This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

From: Maksim Kuznetsov <maks dot kuznetsov at gmail dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, Richard Henderson <rth at redhat dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>, Michael Zolotukhin <michael dot v dot zolotukhin at gmail dot com>, hjl dot tools at gmail dot com, ubizjak at gmail dot com, izamyatin at gmail dot com, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Sergey Ostanevich <sergos dot gnu at gmail dot com>, law at redhat dot com
Date: Mon, 29 Apr 2013 15:39:58 +0400
Subject: Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
References: <CACRX5UJbVCjwyWDH6VvMWCtqZRxaLLDUfk14osz-pZS=XhXHwg at mail dot gmail dot com> <CACRX5U+r8qsC8hZEUg_aU_UiV43c3JBGx7GWgmb-J_svdUMv_g at mail dot gmail dot com> <CANtU078qjAK-qQgjTjTBVve1hW9yCDjVbWNMcttU6yj9jkZx8A at mail dot gmail dot com> <1979C4C7-1452-4167-8F27-E746F1F05AA8 at kernel dot crashing dot org> <CANtU07-TiW5a6fduyOKfKCGfrEmrfDrCgfiTHX6-mm4hMQr8TA at mail dot gmail dot com> <CACRX5UJHYDJAahUKdJjjs8hvkzZV3s9YvV9tYqqGsq1WHMLNQQ at mail dot gmail dot com> <CACRX5U+rnLh0JfqJhLXrFvb_szR0gFtoGYwtAAsBkeMxAziOPA at mail dot gmail dot com> <20130416115548 dot GR12880 at tucnak dot redhat dot com> <516E506E dot 1010308 at redhat dot com> <CACRX5ULb22W0R57HJ52OTTLLeLu9C6aB5P2An=haiOB3aUUUZQ at mail dot gmail dot com> <20130429104126 dot GD28963 at tucnak dot redhat dot com>

2013/4/29 Jakub Jelinek <jakub@redhat.com>:
> Also, why are you handling just %{ and %}, and
> not also %| ?  I mean, if you want to print say {|} into assembly for both
> dialects, don't you need:
> asm ("{dialect1%{%|%}|%{%|%}dialect2}");
> or similar?  If you use just | instead of %|, it would be handled as
> separator of the dialects.

Sure. %| was removed due to concerns over some target architectures
already use it, but now %| is under ASSEMBLER_DIALECT and doesn't seem
to affect them.

ChangeLog:

2013-04-29  Maxim Kuznetsov  <maks.kuznetsov@gmail.com>
    * final.c (do_assembler_dialects): Don't handle curly braces and
    vertical bar escaped by % as dialect delimiters.
    (output_asm_insn): Print curly braces and vertical bar if escaped
    by % and ASSEMBLER_DIALECT defined.
    * doc/tm.texi (ASSEMBLER_DIALECT): Document new standard escapes.

testsuite/ChangeLog:

2013-04-29  Maxim Kuznetsov  <maks.kuznetsov@gmail.com>

    * gcc.target/i386/asm-dialect-2.c: New testcase.

--
Maxim Kuznetsov

Attachment: curly_braces_20130429-2.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
  - From: Jakub Jelinek

References:
- Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
  - From: Maksim Kuznetsov
- Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
  - From: Jakub Jelinek
- Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
  - From: Richard Henderson
- Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
  - From: Maksim Kuznetsov
- Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]