This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Hash table changes from cxx-conversion branch - config part
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Lawrence Crowl <crowl at googlers dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, nickc at redhat dot com, ramana dot radhakrishnan at arm dot com, wilson at tuliptree dot org, sellcey at mips dot com, rdsandiford at googlemail dot com, cgf at gcc dot gnu dot org, ktietz at redhat dot com, rguenther at suse dot de, dnovillo at google dot com
- Date: Fri, 26 Apr 2013 12:47:19 +0200
- Subject: Re: [patch] Hash table changes from cxx-conversion branch - config part
- References: <CAGqM8fbbORKP1N1UKSLO1teMjNdhutvioLvBG4+uRRmhqE=SRQ at mail dot gmail dot com>
Lawrence,
> * config/sol2.c'solaris_comdat_htab
>
> Fold comdat_hash and comdat_eq into new struct comdat_entry_hasher.
[...]
> Index: gcc/ChangeLog
>
> 2013-04-24 Lawrence Crowl <crowl@google.com>
> * config/sol2.c (solaris_comdat_htab):
> Change type to hash_table. Update dependent calls and types.
>
> * config/t-sol2: Update for above.
Just a nit: your ChangeLog entries are formatted strangely: No newline
immetiately after the colons, and better group e.g. all *sol2* entries
together without a blank line between.
Unfortunately, your mail client mangled the patch, so I had to apply it
manually. Once that was done, it survived a i386-pc-solaris2.10
bootstrap without regressions, so the Solaris parts are ok.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University