This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition
- From: Teresa Johnson <tejohnson at google dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Sriraman Tallam <tmsriram at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Li <davidxl at google dot com>
- Date: Wed, 24 Apr 2013 05:55:49 -0700
- Subject: Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition
- References: <CAAs8HmxQidaPqi3fFAjtdrK_d2R1d6uwYD=tJqJD8KYLV1yADQ at mail dot gmail dot com> <20130424045922 dot GT12880 at tucnak dot redhat dot com>
On Tue, Apr 23, 2013 at 9:59 PM, Jakub Jelinek <firstname.lastname@example.org> wrote:
> On Tue, Apr 23, 2013 at 03:58:06PM -0700, Sriraman Tallam wrote:
>> This patch generates labels for cold function parts that are split when
>> using the option -freorder-blocks-and-partition. The cold label name
>> is generated by suffixing ".cold" to the assembler name of the hot
>> This is useful when getting back traces from gdb when the cold function
>> part does get executed.
>> * final.c (final_scan_insn): Generate cold label name by suffixing
>> ".cold" to function's assembler name.
>> * gcc.dg/tree-prof/cold_partition_label.c: New test.
> This doesn't honor NO_DOT_IN_LABEL (and NO_DOLLAR_IN_LABEL).
> Also, don't some function start in cold section and then switch into hot
That's a good question - with the current trunk implementation it can,
but I have a patch that fixes this and many other bugs I found when
trying to use -freorder-blocks-and-partition. I had sent the patch out
for review awhile ago but it still needs review. See:
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02141.html (most recent
version of patch).
Teresa Johnson | Software Engineer | email@example.com | 408-460-2413