This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, AArch64] Compare instruction in shift_extend mode


On 15/04/13 05:37, Hurugalawadi, Naveen wrote:
Hi,

Same issue as my previous reply applies here.

Thanks for the suggestion.

Please find attached the modified patch as per your suggestions.
Please review the same and let me know if there should be any
further modifications in it.

Thanks,
Naveen



Hi,

The .md pattern looks OK. I'm not happy about the test case. It is too fragile. For example, adding -fno-inline such that main does not get optimized away breaks the pattern match. When we run the testsuites here we often do a run with -fPIC in order to increase coverage, that option will also break this test case. I suggest for this one test case either making it compile only and dropping main() such that the pattern match only looks in the assembled output of the cmp_* functions, or leaving the test case execute but removing the pattern match...

Cheers
/Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]