This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)
- From: Teresa Johnson <tejohnson at google dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: reply at codereview dot appspotmail dot com, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Rong Xu <xur at google dot com>
- Date: Wed, 3 Apr 2013 13:54:14 -0700
- Subject: Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)
- References: <20121215021147 dot 58465615D9 at tjsboxrox dot mtv dot corp dot google dot com> <CAAe5K+UB-1TnZUV-iTwgShRhyuOjZbf=UA9vp_dG2_MozvqVaQ at mail dot gmail dot com> <20130403175249 dot GA1595 at atrey dot karlin dot mff dot cuni dot cz>
On Wed, Apr 3, 2013 at 10:52 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> >
>> > 2012-12-14 Teresa Johnson <tejohnson@google.com>
>> >
>> > * lto-cgraph.c (input_symtab): Replace call to compute_working_sets
>> > to get_working_sets.
>> > * gcov-io.c (compute_working_sets): Moved most of body of old
>> > compute_working_sets here from profile.c.
>> > * gcov-io.h (NUM_GCOV_WORKING_SETS): Moved here from profile.c.
>> > (gcov_working_set_t): Moved typedef here from basic-block.h
>> > (compute_working_set): Declare.
>> > * profile.c (NUM_GCOV_WORKING_SETS): Moved to gcov-io.h.
>> > (get_working_sets): Renamed from compute_working_set,
>> > replace most of body with call to new compute_working_sets.
>> > (get_exec_counts): Replace call to compute_working_sets
>> > to get_working_sets.
>> > * profile.h (get_working_sets): Renamed from
>> > compute_working_set.
>> > * basic-block.h (gcov_working_set_t): Moved to gcov-io.h.
>> > * gcov-dump.c (dump_working_sets): New function.
>
> Looks like good idea. We probaby couold extend gcov-dump to also compute the real
> histogram across multiple input files and compare these two.
cc'ing Rong Xu - he has a tool under development that he plans to
contribute upstream which does both offline merging of different sets
of profile data, and full, exact recomputation of the histogram. I'm
using an early version of his tool right now to compare the accuracy
of the libgcov-merged histogram to the exactly merged histogram (I'll
update the thread on that hopefully later today).
>
> Patch is OK.
Thanks, committed.
Teresa
> Thanks,
> Honza
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413