This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)


> >
> > 2012-12-14  Teresa Johnson  <tejohnson@google.com>
> >
> >         * lto-cgraph.c (input_symtab): Replace call to compute_working_sets
> >         to get_working_sets.
> >         * gcov-io.c (compute_working_sets): Moved most of body of old
> >         compute_working_sets here from profile.c.
> >         * gcov-io.h (NUM_GCOV_WORKING_SETS): Moved here from profile.c.
> >         (gcov_working_set_t): Moved typedef here from basic-block.h
> >         (compute_working_set): Declare.
> >         * profile.c (NUM_GCOV_WORKING_SETS): Moved to gcov-io.h.
> >         (get_working_sets): Renamed from compute_working_set,
> >         replace most of body with call to new compute_working_sets.
> >         (get_exec_counts): Replace call to compute_working_sets
> >         to get_working_sets.
> >         * profile.h (get_working_sets): Renamed from
> >         compute_working_set.
> >         * basic-block.h (gcov_working_set_t): Moved to gcov-io.h.
> >         * gcov-dump.c (dump_working_sets): New function.

Looks like good idea.  We probaby couold extend gcov-dump to also compute the real
histogram across multiple input files and compare these two.

Patch is OK.
Thanks,
Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]