This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Teresa Johnson <tejohnson at google dot com>
- Cc: reply at codereview dot appspotmail dot com, Jan Hubicka <hubicka at ucw dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 3 Apr 2013 19:52:49 +0200
- Subject: Re: [PATCH] Compute and emit working set information from gcov-dump (issue6940061)
- References: <20121215021147 dot 58465615D9 at tjsboxrox dot mtv dot corp dot google dot com> <CAAe5K+UB-1TnZUV-iTwgShRhyuOjZbf=UA9vp_dG2_MozvqVaQ at mail dot gmail dot com>
> >
> > 2012-12-14 Teresa Johnson <tejohnson@google.com>
> >
> > * lto-cgraph.c (input_symtab): Replace call to compute_working_sets
> > to get_working_sets.
> > * gcov-io.c (compute_working_sets): Moved most of body of old
> > compute_working_sets here from profile.c.
> > * gcov-io.h (NUM_GCOV_WORKING_SETS): Moved here from profile.c.
> > (gcov_working_set_t): Moved typedef here from basic-block.h
> > (compute_working_set): Declare.
> > * profile.c (NUM_GCOV_WORKING_SETS): Moved to gcov-io.h.
> > (get_working_sets): Renamed from compute_working_set,
> > replace most of body with call to new compute_working_sets.
> > (get_exec_counts): Replace call to compute_working_sets
> > to get_working_sets.
> > * profile.h (get_working_sets): Renamed from
> > compute_working_set.
> > * basic-block.h (gcov_working_set_t): Moved to gcov-io.h.
> > * gcov-dump.c (dump_working_sets): New function.
Looks like good idea. We probaby couold extend gcov-dump to also compute the real
histogram across multiple input files and compare these two.
Patch is OK.
Thanks,
Honza