This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] Adding -fno-pic to certain tests
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Alexander Ivchenko <aivchenk at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Maxim Kuvyrkov <maxim dot kuvyrkov at gmail dot com>
- Date: Mon, 25 Mar 2013 10:28:46 +0100
- Subject: Re: [testsuite] Adding -fno-pic to certain tests
- References: <CACysShhue6DwbYt0s5GZO-SYS782wNZ1GxJBLkruFyzZX-T8Ow at mail dot gmail dot com> <CAFiYyc1mA4UCp8oHUWeu9z+cVDd+1Z+gF6FgSrkJBJk262ZnkA at mail dot gmail dot com> <CACysShg8swUpxs24rKZ5hcFwJ4FDM2iqs_2KStGd3w_2ThT0uQ at mail dot gmail dot com>
On Sun, Mar 24, 2013 at 7:49 AM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> Hi,
>
> Finally got my hands on that: the attached patch adds the
> "target nonpic" for those tests that require the avaiability of
> functions defined in them.
>
> OK for trunk?
For testsuite/gcc.target/i386/mmx-1.c you still don't use nopic.
Please fix that.
Ok with that change.
Thanks,
Richard.
> thanks,
> Alexander
>
>
> 2013/1/10 Richard Biener <richard.guenther@gmail.com>:
>> On Thu, Jan 10, 2013 at 2:50 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>>> Hi,
>>>
>>> It all begun with discussion here
>>> http://gcc.gnu.org/ml/gcc/2012-11/msg00205.html
>>>
>>> Since -fpic option is turned on by default in Android we have certain test
>>> fails. The reason for that is that those tests rely on the
>>> availability of functions, defined in them
>>> and with -fpic compiler conservatively assumes that they are AVAIL_OVERWRITABLE.
>>>
>>> The attached patch adding -fno-pic option for tests that fail because of that.
>>
>> I think this should be a dg-requires nopic instead. Otherwise testing
>> with -fPIC/-fno-pic will not show expected differences.
>>
>> Richard.
>>
>>> 2013-01-10 Alexander Ivchenko <alexander.ivchenko@intel.com>
>>>
>>> * g++.dg/ipa/ivinline-1.C: Add -fno-pic option.
>>> * g++.dg/ipa/ivinline-2.C: Likewise.
>>> * g++.dg/ipa/ivinline-3.C: Likewise.
>>> * g++.dg/ipa/ivinline-4.C: Likewise.
>>> * g++.dg/ipa/ivinline-5.C: Likewise.
>>> * g++.dg/ipa/ivinline-7.C: Likewise.
>>> * g++.dg/ipa/ivinline-8.C: Likewise.
>>> * g++.dg/ipa/ivinline-9.C: Likewise.
>>> * g++.dg/cpp0x/noexcept03.C: Likewise.
>>> * gcc.dg/const-1.c: Likewise.
>>> * gcc.dg/ipa/pure-const-1.c: Likewise.
>>> * gcc.dg/noreturn-8.c: Likewise.
>>> * gcc.dg/tree-ssa/ipa-split-5.c: Likewise.
>>> * gcc.dg/tree-ssa/loadpre6.c: Likewise.
>>> * gcc.c-torture/execute/pr33992.c: Likewise.
>>> * gcc.c-torture/execute/pr33992.x: New file.
>>>
>>> ok for mainline?
>>>
>>> thanks,
>>> Alexander