This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Rename DECL_DEBUG_EXPR_IS_FROM to DECL_HAS_DEBUG_EXPR_P
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 20 Mar 2013 14:10:35 +0100
- Subject: Re: [PATCH] Rename DECL_DEBUG_EXPR_IS_FROM to DECL_HAS_DEBUG_EXPR_P
- References: <alpine dot LNX dot 2 dot 00 dot 1303201356060 dot 3543 at zhemvz dot fhfr dot qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Mar 20, 2013 at 01:57:40PM +0100, Richard Biener wrote:
> As discussed previously on IRC this patch does the renaming from
> the confusing DECL_DEBUG_EXPR_IS_FROM to DECL_HAS_DEBUG_EXPR_P
> which matches DECL_HAS_VALUE_EXPR_P (and it's behavior).
Not sure if we actually guarantee that if DECL_HAS_DEBUG_EXPR_P, then
it has non-NULL DECL_DEBUG_EXPR. I'm worried about copy_node somewhere
copying a decl together with DECL_HAS_DEBUG_EXPR_P bit, but not adding
anything into the hash table, or about LTO.
Otherwise it looks good.
Jakub