This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, libfortran] PR51825 - Fortran runtime error: Cannot match namelist object name


Hi Tilo,

I have now committed your two patches.
* PR 48618 - Negative unit number in OPEN(...) is sometimes allowed (as Rev. 196805) which was approved here: http://thread.gmane.org/gmane.comp.gcc.fortran/40435/focus=40455 (It's not in the gcc.gnu.org/ml/fortran as the server didn't record the mails at that point)
* This patch (as Rev. 196806)

Congratulation to the committal of your first two patches - and thanks again for your work.


Two remarks:

Tilo Schwarz wrote:
2013-03-07  Tilo Schwarz<tilo@tilo-schwarz.de>

	PR libfortran/51825
	* io/list_read.c (nml_read_obj): Don't end the component loop on a
	nested derived type, but continue with the next loop iteration.
	(nml_get_obj_data): Don't move the first_nl pointer further in the
	list if a qualifier was found.
	* gcc/testsuite/gfortran.dg/namelist_77.f90: New.
	* gcc/testsuite/gfortran.dg/namelist_78.f90: New.

The change log ends up in two files: libgfortran/ChangeLog and gcc/testsuite/ChangeLog. File names are relative to those files. Hence, I removed "gcc/testsuite/" before committal.

+++ b/gcc/testsuite/gfortran.dg/namelist_77.f90
@@ -0,0 +1,48 @@
+! { dg-do run }
+! PR 51825 - Fortran runtime error: Cannot match namelist object name
+! Test case derived from PR.
...
+++ b/gcc/testsuite/gfortran.dg/namelist_78.f90
@@ -0,0 +1,32 @@
+! { dg-do run }
+! Test case regarding namelist problems with derived types

It is useful to quickly see from which bug/problem report the test case came from. Thus, I added "PR libfortran/51825". (Using PR 51825 is also fine; btw. there is no need to add a full link to Bugzilla as the PR number is sufficient.)

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]