This is the mail archive of the
mailing list for the GCC project.
Re: [patch] Make dse.c dumps less verbose unless dumping details
- From: Jeff Law <law at redhat dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 11 Mar 2013 12:07:51 -0600
- Subject: Re: [patch] Make dse.c dumps less verbose unless dumping details
- References: <CABu31nM5SH7KtVkDcf_vGQJHSj8-Oz26eF-G=YGDaEjWTpqA2g@mail.gmail.com>
On 03/09/2013 12:59 PM, Steven Bosscher wrote:
Hello,Given we're trying to wrap up 4.8 and get an RC out, I would have
preferred this not go in. It's not strictly necessary to get 4.8 out
Debugging a DSE bug, I found the dumps to be almost unusable because
they are so verbose. For my test case, the -fdump-rtl-dse1 dump is a
~17GB file without the attached patch (the test case has ~50000
insns). With the patch, all this extra information is only dumped with
Bootstrapped&tested on x86_64-unknown-linux-gnu and
powerpc64-unknown-linux-gnu. Will commit as obvious.
* dse.c (delete_dead_store_insn): Respect TDF_DETAILS.
(canon_address, record_store, replace_read, check_mem_read_rtx,
scan_insn, dse_step1, dse_step2_init, dse_step2_spill,
dse_step4, dse_step5_nospill, dse_step5_spill, dse_step6,
Regardless, it's done and I'm certainly not going to suggest pulling the
patch out. In the future, please avoid any non-critical checkins this
late in the game.